-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dep update + commonjs -> module #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmattgray
force-pushed
the
chore/dep-update
branch
from
October 17, 2022 17:52
bf48363
to
007f1c7
Compare
jonmattgray
force-pushed
the
chore/dep-update
branch
from
October 17, 2022 17:55
007f1c7
to
8d114dc
Compare
jonmattgray
commented
Oct 17, 2022
jonmattgray
commented
Oct 17, 2022
jonmattgray
commented
Oct 17, 2022
jonmattgray
requested review from
mattdean-digicatapult and
n3op2
as code owners
October 17, 2022 18:24
dblane-digicatapult
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade the 'dscp-node' dep in chart.yaml
mattdean-digicatapult
previously approved these changes
Oct 18, 2022
jonmattgray
requested review from
dblane-digicatapult and
mattdean-digicatapult
October 19, 2022 15:52
dblane-digicatapult
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades deps to latest and switch to module syntax.
formdata-node
andmocharc.cjs
similar to Upgrade deps and switch from commonjs -> module dscp-api#59fileURLToPath(import.meta.url)
to get__dirname
Otherwise see my comments on files